Add onBeforeRestoreAll and onRestoreAll #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`onBeforeRestore` and `onRestore` are now granular and provide the target form. They also don't trigger if there is no data to restore for that particular form. `onBeforeRestoreAll` and `onRestoreAll` operate like `onBeforeRestore` and `onRestore` used to. No tests so far.
|
I just wanted to float this concept before cleaning it up (documentation and tests). What do you think? I know it breaks the existing API but it's better to rename the methods to |
|
Ended up rolling my own solution in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBeforeRestoreandonRestoreare now granular and provide the target form. They also don't trigger if there is no data to restore for that particular form.onBeforeRestoreAllandonRestoreAlloperate likeonBeforeRestoreandonRestoreused to.No tests so far.
Potential to close #138 with more work.